Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resolve): deep import resolvedId error #13010

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

btea
Copy link
Collaborator

@btea btea commented Apr 26, 2023

Description

temporal fix for #12997 (edited by @patak-dev)
rel #12461

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Apr 26, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

@bluwy leaving a reference of why we are adding the extension to the original id here: #8348 (comment)

I was never sure if this was the right approach though, and it has continued to bring issues. We could merge this PR as a temporal patch if it fixes the issue at hand but we need to review how we handle externalization in a holistic way in the next minor or Vite 5. Hopefully removing the need for the current double resolve we nee to know if it should externalize in SSR.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this guard makes sense, at least as a temporal patch to the problem. There are cases where resolved.id doesn't start with id, so it is probable we may not remove this guard later on. Let's merge it so we can do a release but leave the issue open to track a long-term solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants